linux-kernel - Re: [PATCH v7 11/12] leds: Add common LED binding parsing support to LED class/core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5988a961ede536114d1f9eff449fd8f91edb49b.camel@fi.rohmeurope.com>
Date:   Mon, 23 Dec 2019 10:35:51 +0000
From:   "Vaittinen, Matti" <Matti.Vaittinen@...rohmeurope.com>
To:     "pavel@....cz" <pavel@....cz>
CC:     "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "dmurphy@...com" <dmurphy@...com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "jacek.anaszewski@...il.com" <jacek.anaszewski@...il.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "bgolaszewski@...libre.com" <bgolaszewski@...libre.com>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "broonie@...nel.org" <broonie@...nel.org>
Subject: Re: [PATCH v7 11/12] leds: Add common LED binding parsing support
 to LED class/core

Hello Pavel,

On Sat, 2019-12-21 at 20:37 +0100, Pavel Machek wrote:
> Hi!
> 
> > Qucik grep for 'for_each' or 'linux,default-trigger' or
> 
> quick.
> 
> > If init_data is goven but no starting point for node lookup - then
> 
> is given.
> 
> > (parent) device's own DT node is used. If no led-compatible is
> > given,
> > then of_match is searched for. If neither led-compatible not
> > of_match
> 
> nor of_match.
> 
> > is given then device's own node or passed starting point are used
> > as
> > such.
> > 
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> > ---
> > 
> > No changes since v6
> > 
> >  drivers/leds/led-class.c |  99 +++++++++++++--
> >  drivers/leds/led-core.c  | 258 ++++++++++++++++++++++++++++++++---
> > ----
> >  include/linux/leds.h     |  94 ++++++++++++--
> >  3 files changed, 385 insertions(+), 66 deletions(-)
> 
> Quite a lot of code added here. Can I trust you that we we'll delete
> 320 lines by converting driver or two?

I believe we do. Besides bunch of the lines are comments. I don't think
I actually added much of new things here. And one thing we should not
overlook is the drivers to come. I believe amount of LED devices we
will be getting drivers for will increase. 320 lines is peanuts if we
get 5 new drivers all implementing the same DT parsing loop.

Anyways, I will look all of the comments thoroughly during next Friday.
I am currently having a vacation and I might get strangled by my family
if I spend it staring at the computer xD

Thanks for taking the time to look at this! I do appreciate the effort!

Br,
	Matti Vaittinen