linux-kernel - [PATCH] pstore/ram: fix for adding dumps to non-empty zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191223133816.28155-1-n.merinov@inango-systems.com>
Date:   Mon, 23 Dec 2019 18:38:16 +0500
From:   Nikolai Merinov <n.merinov@...ngo-systems.com>
To:     Kees Cook <keescook@...omium.org>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org
Cc:     Aleksandr Yashkin <a.yashkin@...ngo-systems.com>,
        Nikolay Merinov <n.merinov@...ngo-systems.com>,
        Ariel Gilman <a.gilman@...ngo-systems.com>
Subject: [PATCH] pstore/ram: fix for adding dumps to non-empty zone

From: Aleksandr Yashkin <a.yashkin@...ngo-systems.com>

The circle buffer in ramoops zones has a problem for adding a new
oops dump to already an existing one.

The solution to this problem is to reset the circle buffer state before
writing a new oops dump.

Signed-off-by: Aleksandr Yashkin <a.yashkin@...ngo-systems.com>
Signed-off-by: Nikolay Merinov <n.merinov@...ngo-systems.com>
Signed-off-by: Ariel Gilman <a.gilman@...ngo-systems.com>

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index 8caff834f002..33fceadbf515 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -407,6 +407,13 @@ static int notrace ramoops_pstore_write(struct pstore_record *record)
 
 	prz = cxt->dprzs[cxt->dump_write_cnt];
 
+	/* Clean the buffer from old info.
+	 * `ramoops_read_kmsg_hdr' expects to find a header in the beginning of
+	 * buffer data, so we must to reset the buffer values, in order to
+	 * ensure that the header will be written to the beginning of the buffer
+	 */
+	persistent_ram_zap(prz);
+
 	/* Build header and append record contents. */
 	hlen = ramoops_write_kmsg_hdr(prz, record);
 	if (!hlen)
-- 
2.17.1