linux-kernel - Re: [PATCH] sched: Use kmem_cache_zalloc() instead of kmem_cache_alloc() with flag GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Dec 2019 17:07:50 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Yi Wang <wang.yi59@....com.cn>,
        Huang Zijiang <huang.zijiang@....com.cn>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Ben Segall <bsegall@...gle.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Mel Gorman <mgorman@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>, up2wing@...il.com,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Wang Liang <wang.liang82@....com.cn>,
        Xue Zhihong <xue.zhihong@....com.cn>
Subject: Re: [PATCH] sched: Use kmem_cache_zalloc() instead of
 kmem_cache_alloc() with flag GFP_ZERO.

…
> +++ b/kernel/sched/core.c
> @@ -6939,7 +6939,7 @@ struct task_group *sched_create_group(struct task_group *parent)
…
> -    tg = kmem_cache_alloc(task_group_cache, GFP_KERNEL | __GFP_ZERO);
> +tg = kmem_cache_zalloc(task_group_cache, GFP_KERNEL);
>      if (!tg)
…

Please fix the indentation.

Would you like to apply a script for the semantic patch language
like the following?

@replacement@
expression gfp, x;
@@
 x =
(
-    kmalloc
+    kzalloc
|
-    kmem_cache_alloc
+    kmem_cache_zalloc
)
            (...,
             gfp
-            | __GFP_ZERO
            )


Regards,
Markus