linux-kernel - Re: [selinux] 66f8e2f03c: RIP:sidtab_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhQTphqNxZ7ndNRCy-iff3ugFjLan+CoWT8v6joF_smNzg@mail.gmail.com>
Date:   Mon, 23 Dec 2019 16:37:40 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     Jeff Vander Stoep <jeffv@...gle.com>
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Jovana Knezevic <jovanak@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>, selinux@...r.kernel.org,
        lkp@...ts.01.org, kernel test robot <lkp@...el.com>
Subject: Re: [selinux] 66f8e2f03c: RIP:sidtab_hash_stats

On Mon, Dec 23, 2019 at 9:37 AM Paul Moore <paul@...l-moore.com> wrote:
>
> On Mon, Dec 23, 2019 at 4:15 AM kernel test robot <lkp@...el.com> wrote:
> > FYI, we noticed the following commit (built with gcc-7):
> >
> > commit: 66f8e2f03c02e812002f8e9e465681cc62edda5b ("selinux: sidtab reverse lookup hash table")
> > https://git.kernel.org/cgit/linux/kernel/git/pcmoore/selinux.git next
> >
> > ...
>
> Jeff, please look into this.  I suspect we may need to check
> state->initialized in security_sidtab_hash_stats(...) (or similar).

I realized that Jeff may very well be on a holiday so I took a closer
look and this does appear to be the/a problem.  If you try to "cat
/sys/fs/selinux/ss/sidtab_hash_stats" on a system where the policy
hasn't been loaded it blows up in a bad way.  I'll write up a fix
right now and post it as soon as I've verified it fixes the problem.

-- 
paul moore
www.paul-moore.com