linux-kernel - RE: [PATCH v2] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01fc01d5ba25$b2b12dd0$18138970$@codeaurora.org>
Date:   Tue, 24 Dec 2019 12:15:10 +0530
From:   <pillair@...eaurora.org>
To:     "'Matthias Kaehlcke'" <mka@...omium.org>
Cc:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node

Hi MItthias,

> -----Original Message-----
> From: Matthias Kaehlcke <mka@...omium.org>
> Sent: Thursday, December 19, 2019 11:18 PM
> To: Rakesh Pillai <pillair@...eaurora.org>
> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org; linux-arm-msm@...r.kernel.org
> Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node
> 
> On Thu, Dec 19, 2019 at 01:15:21PM +0530, Rakesh Pillai wrote:
> > Add device node for the ath10k SNOC platform driver probe
> > and add resources required for WCN3990 on sc7180 soc.
> >
> > Signed-off-by: Rakesh Pillai <pillair@...eaurora.org>
> > ---
> 
> This does not apply cleanly against the current qcom/arm64-for-5.6
> or for-next branch, looks like you need to rebase.
> 
> >  arch/arm64/boot/dts/qcom/sc7180-idp.dts |  5 +++++
> >  arch/arm64/boot/dts/qcom/sc7180.dtsi    | 28
> ++++++++++++++++++++++++++++
> >  2 files changed, 33 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 189254f..b2ca143f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -248,6 +248,11 @@
> >  	status = "okay";
> >  };
> >
> > +&wifi {
> > +	status = "okay";
> > +	qcom,msa_fixed_perm;
> 
> What is the status of the patch adding this flag?

This patch is currently under review (https://patchwork.kernel.org/patch/11236535/)
It hasn’t been acked yet.

> 
> > +};
> > +
> >  /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> >
> >  &qup_i2c2_default {
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 666e9b9..ce2d2a5 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -42,6 +42,12 @@
> >  			compatible = "qcom,cmd-db";
> >  			no-map;
> >  		};
> > +
> > +		wlan_fw_mem: memory@...00000 {
> > +			compatible = "removed-dma-pool";
> > +			no-map;
> > +			reg = <0 0x93900000 0 0x200000>;
> > +		};
> >  	};
> >
> >  	cpus {
> > @@ -1119,6 +1125,28 @@
> >  				#clock-cells = <1>;
> >  			};
> >  		};
> > +
> > +		wifi: wifi@...00000 {
> > +			status = "disabled";
> 
> nit: the convention seems to be to add this at the end of the node,
> which IMO makes sense since most other fields provide more 'interesting'
> information.

I will send out an updated patchset, moving "status=disabled" down