[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191224114504.2f256ab9@nic.cz>
Date: Tue, 24 Dec 2019 11:45:04 +0100
From: Marek Behun <marek.behun@....cz>
To: Mao Wenan <maowenan@...wei.com>
Cc: <andrew@...n.ch>, <vivien.didelot@...il.com>,
<f.fainelli@...il.com>, <davem@...emloft.net>,
<linux@...pel-privat.de>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: drop pointless static qualifier in
ar9331_sw_mbus_init
Hi Mao,
the commit title should be something of the form
net: dsa: qca: ar9331: drop pointless static qualifier
or
net: dsa: ar9331: drop pointless static qualifier
If it begins only with
net: dsa:
then it makes people think you are changing stuff in main dsa code.
Marek
On Tue, 24 Dec 2019 10:40:59 +0800
Mao Wenan <maowenan@...wei.com> wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.
>
> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> ---
> drivers/net/dsa/qca/ar9331.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
> index 0d1a7cd85fe8..da3bece75e21 100644
> --- a/drivers/net/dsa/qca/ar9331.c
> +++ b/drivers/net/dsa/qca/ar9331.c
> @@ -266,7 +266,7 @@ static int ar9331_sw_mbus_read(struct mii_bus *mbus, int port, int regnum)
> static int ar9331_sw_mbus_init(struct ar9331_sw_priv *priv)
> {
> struct device *dev = priv->dev;
> - static struct mii_bus *mbus;
> + struct mii_bus *mbus;
> struct device_node *np, *mnp;
> int ret;
>
Powered by blists - more mailing lists