linux-kernel - Re: [PATCH] powerpc/shared: include correct header for static key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20191224162250.GA1781@linux.vnet.ibm.com>
Date:   Tue, 24 Dec 2019 21:52:50 +0530
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     pauld@...hat.com, longman@...hat.com, mpe@...erman.id.au,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/shared: include correct header for static key

* Jason A. Donenfeld <Jason@...c4.com> [2019-12-23 14:31:47]:

> Recently, the spinlock implementation grew a static key optimization,
> but the jump_label.h header include was left out, leading to build
> errors:
> 
> linux/arch/powerpc/include/asm/spinlock.h:44:7: error: implicit declaration of function ???static_branch_unlikely??? [-Werror=implicit-function-declaration]
>    44 |  if (!static_branch_unlikely(&shared_processor))
> 
> This commit adds the missing header.

Right, This was in v4 version of the patchset
(http://lkml.kernel.org/r/20191212085344.17357-1-srikar@linux.vnet.ibm.com)
but we missed it in the final v5 version.

Thanks for noticing and fixing it.

Reviewed-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

> 
> Fixes: 656c21d6af5d ("powerpc/shared: Use static key to detect shared processor")
> Cc: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> ---
>  arch/powerpc/include/asm/spinlock.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/include/asm/spinlock.h b/arch/powerpc/include/asm/spinlock.h
> index 1b55fc08f853..860228e917dc 100644
> --- a/arch/powerpc/include/asm/spinlock.h
> +++ b/arch/powerpc/include/asm/spinlock.h
> @@ -15,6 +15,7 @@
>   *
>   * (the type definitions are in asm/spinlock_types.h)
>   */
> +#include <linux/jump_label.h>
>  #include <linux/irqflags.h>
>  #ifdef CONFIG_PPC64
>  #include <asm/paca.h>
> -- 
> 2.24.1
> 

-- 
Thanks and Regards
Srikar Dronamraju