linux-kernel - Re: [PATCH -next] selinux: remove set but not used variable 'sidtab'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Dec 2019 14:35:56 -0500
From:   Paul Moore <paul@...l-moore.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>, omosnace@...hat.com,
        rgb@...hat.com, keescook@...omium.org, casey@...aufler-ca.com,
        jeffv@...gle.com, kent.overstreet@...il.com,
        selinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] selinux: remove set but not used variable 'sidtab'

On Tue, Dec 24, 2019 at 7:46 AM YueHaibing <yuehaibing@...wei.com> wrote:
> security/selinux/ss/services.c: In function security_port_sid:
> security/selinux/ss/services.c:2346:17: warning: variable sidtab set but not used [-Wunused-but-set-variable]
> security/selinux/ss/services.c: In function security_ib_endport_sid:
> security/selinux/ss/services.c:2435:17: warning: variable sidtab set but not used [-Wunused-but-set-variable]
> security/selinux/ss/services.c: In function security_netif_sid:
> security/selinux/ss/services.c:2480:17: warning: variable sidtab set but not used [-Wunused-but-set-variable]
> security/selinux/ss/services.c: In function security_fs_use:
> security/selinux/ss/services.c:2831:17: warning: variable sidtab set but not used [-Wunused-but-set-variable]
>
> Since commit 66f8e2f03c02 ("selinux: sidtab reverse lookup hash table")
> 'sidtab' is not used any more, so remove it.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  security/selinux/ss/services.c | 8 --------
>  1 file changed, 8 deletions(-)

Merged into selinux/next, thanks!

-- 
paul moore
www.paul-moore.com