linux-kernel - Re: [PATCH] mv88e6xxx: Add serdes Rx statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201912250656.5vtkCiCE%lkp@intel.com>
Date:   Wed, 25 Dec 2019 06:17:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     kbuild-all@...ts.01.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Chris Healy <cphealy@...il.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>
Subject: Re: [PATCH] mv88e6xxx: Add serdes Rx statistics

Hi Nikita,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[cannot apply to net/master sparc-next/master v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nikita-Yushchenko/mv88e6xxx-Add-serdes-Rx-statistics/20191225-033913
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git ac80010fc94eb0680d9a432b639583bd7ac29066
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/dsa/mv88e6xxx/serdes.c: In function 'mv88e6390_serdes_power':
>> drivers/net/dsa/mv88e6xxx/serdes.c:506:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
      ret = mv88e6390_serdes_power_sgmii(chip, lane, up);
      ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/dsa/mv88e6xxx/serdes.c:507:2: note: here
     case MV88E6XXX_PORT_STS_CMODE_XAUI:
     ^~~~

vim +506 drivers/net/dsa/mv88e6xxx/serdes.c

   495	
   496	int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, u8 lane,
   497				   bool up)
   498	{
   499		u8 cmode = chip->ports[port].cmode;
   500		int ret = 0;
   501	
   502		switch (cmode) {
   503		case MV88E6XXX_PORT_STS_CMODE_SGMII:
   504		case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
   505		case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
 > 506			ret = mv88e6390_serdes_power_sgmii(chip, lane, up);
   507		case MV88E6XXX_PORT_STS_CMODE_XAUI:
   508		case MV88E6XXX_PORT_STS_CMODE_RXAUI:
   509			ret = mv88e6390_serdes_power_10g(chip, lane, up);
   510		}
   511	
   512		if (!ret && up)
   513			ret = mv88e6390_serdes_enable_checker(chip, lane);
   514	
   515		return ret;
   516	}
   517	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50722 bytes)