linux-kernel - Re: [PATCH] mtd: spi-nor: make s25fl129p1 skip SFDP parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f0a49d4-b693-f18d-50ff-4ad5b4fc05e3@microchip.com>
Date:   Tue, 24 Dec 2019 00:29:18 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <jiwei.sun@...driver.com>, <linux-kernel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>
CC:     <miquel.raynal@...tlin.com>, <richard@....at>, <vigneshr@...com>,
        <jiwei.sun.bj@...com>
Subject: Re: [PATCH] mtd: spi-nor: make s25fl129p1 skip SFDP parsing

Hi, Jiwei,

On 12/19/19 10:12 AM, Jiwei Sun wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: jsun4 <jiwei.sun@...driver.com>
> 
> The right page size of S25FL129P has been gotten in the function
> spi_nor_info_init_params() before invoking spi_nor_parse_bfpt(),
> it is 256-bytes, but the size will be changed to 512 bytes in the
> following function spi_nor_parse_bfpt(). And there is no explanation of
> the SFDP according to the datasheet of S25FL129P. So we can skip
> SFDP parsing.
> 

Would you please dump the sfdp so that we can check what's going on?
If the BFPT table has the page size param wrong, we can use the
post_bfpt hook to correct it. This way we will still benefit of
the rest of the info from BFPT.

Cheers,
ta