linux-kernel - Re: [PATCH] drivers: clk: make gpio-gated clock support optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191224030050.59E95206B7@mail.kernel.org>
Date:   Mon, 23 Dec 2019 19:00:49 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        linux-kernel@...r.kernel.org
Cc:     mturquette@...libre.com, matthias.bgg@...il.com,
        linux-clk@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH] drivers: clk: make gpio-gated clock support optional

Quoting Enrico Weigelt, metux IT consult (2019-12-19 10:19:14)
> The gpio-gate-clock / gpio-mux-clock driver isn't used much,
> just by a few ARM SoCs, so there's no need to always include
> it unconditionally.
> 
> Thus make it optional, but keep it enabled by default.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  drivers/clk/Kconfig  | 7 +++++++
>  drivers/clk/Makefile | 2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 45653a0e6ecd..880f89c46f6f 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -23,6 +23,13 @@ config COMMON_CLK
>  menu "Common Clock Framework"
>         depends on COMMON_CLK
>  
> +config COMMON_CLK_GPIO
> +       tristate "GPIO gated clock support"
> +       default y

Maybe make it depend on GPIOLIB and default to that too?

Otherwise sounds OK to me.