linux-kernel - Re: [PATCH] PM / devfreq: exynos-bus: Add error log when get event fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7230b556-7a96-14d1-ed22-43b5a6cd5a71@samsung.com>
Date:   Tue, 24 Dec 2019 13:07:05 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Yangtao Li <tiny.windzz@...il.com>, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com, kgene@...nel.org, krzk@...nel.org
Cc:     linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / devfreq: exynos-bus: Add error log when get event
 fails

Hi,

I think that you better to use 'devfreq-event' instead of just 'event'
as following:

PM / devfreq: exynos-bus: Add error log when fail to get devfreq-event

On 12/24/19 4:19 AM, Yangtao Li wrote:
> Adding an error log makes it easier to trace the function's error path.
> Because the error code may be rewritten on return, print error code here.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/devfreq/exynos-bus.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
> index 948e9340f91c..634d63fd00ea 100644
> --- a/drivers/devfreq/exynos-bus.c
> +++ b/drivers/devfreq/exynos-bus.c
> @@ -126,6 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev,
>  
>  	ret = exynos_bus_get_event(bus, &edata);
>  	if (ret < 0) {
> +		dev_err(dev, "failed to get event from devfreq-event devices %d\n",
> +			ret);

Better to make it under 80 char as following:

diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c
index f5d4c369c7fb..10f4fa1a0363 100644
--- a/drivers/devfreq/exynos-bus.c
+++ b/drivers/devfreq/exynos-bus.c
@@ -126,7 +126,8 @@ static int exynos_bus_get_dev_status(struct device *dev,
 
        ret = exynos_bus_get_event(bus, &edata);
        if (ret < 0) {
-               dev_err(dev, "failed to get event from devfreq-event devices %d\n",
+               dev_err(dev,
+                       "failed to get event from devfreq-event devices %d\n",
                        ret);
                stat->total_time = stat->busy_time = 0;
                goto err;


>  		stat->total_time = stat->busy_time = 0;
>  		goto err;
>  	}
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics