linux-kernel - Re: [PATCH net-next v8 04/14] ethtool: support for netlink notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb4ab157-d6b5-4c41-b5ed-806568884ddc@gmail.com>
Date:   Mon, 23 Dec 2019 20:16:55 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Johannes Berg <johannes@...solutions.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v8 04/14] ethtool: support for netlink
 notifications



On 12/22/2019 3:45 PM, Michal Kubecek wrote:
> Add infrastructure for ethtool netlink notifications. There is only one
> multicast group "monitor" which is used to notify userspace about changes
> and actions performed. Notification messages (types using suffix _NTF)
> share the format with replies to GET requests.
> 
> Notifications are supposed to be broadcasted on every configuration change,
> whether it is done using the netlink interface or ioctl one. Netlink SET
> requests only trigger a notification if some data is actually changed.
> 
> To trigger an ethtool notification, both ethtool netlink and external code
> use ethtool_notify() helper. This helper requires RTNL to be held and may
> sleep. Handlers sending messages for specific notification message types
> are registered in ethnl_notify_handlers array. As notifications can be
> triggered from other code, ethnl_ok flag is used to prevent an attempt to
> send notification before genetlink family is registered.
> 
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian