linux-kernel - Re: [PATCH net] net: dsa: bcm_sf2: Fix IP fragment location and behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191224.160944.944924950432766934.davem@davemloft.net>
Date:   Tue, 24 Dec 2019 16:09:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix IP fragment location and
 behavior

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 20 Dec 2019 11:24:21 -0800

> The IP fragment is specified through user-defined field as the first
> bit of the first user-defined word. We were previously trying to extract
> it from the user-defined mask which could not possibly work. The ip_frag
> is also supposed to be a boolean, if we do not cast it as such, we risk
> overwriting the next fields in CFP_DATA(6) which would render the rule
> inoperative.
> 
> Fixes: 7318166cacad ("net: dsa: bcm_sf2: Add support for ethtool::rxnfc")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks Florian.