linux-kernel - Re: [PATCH] ARM: dts: Add omap3-echo

Open Source and information security mailing list archives

Message-ID: <CAHCN7xKMnfo5reY+VSs_iCv_NXs-E12dFcRXonz6cNe1-huSPQ@mail.gmail.com>
Date:   Wed, 25 Dec 2019 06:53:18 -0600
From:   Adam Ford <aford173@...il.com>
To:     André Hentschel <nerv@...ncrow.de>
Cc:     Tony Lindgren <tony@...mide.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Russell King <linux@....linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Benoît Cousson <bcousson@...libre.com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        arm-soc <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: Add omap3-echo

On Wed, Dec 25, 2019 at 6:05 AM André Hentschel <nerv@...ncrow.de> wrote:
>
> Am 24.12.19 um 19:45 schrieb Tony Lindgren:
> > * André Hentschel <nerv@...ncrow.de> [191224 16:11]:
> >> This is the first generation Amazon Echo from 2016.
> >> Audio support is not yet implemented.
> >
> > OK looks good to me, just worried about one part:
> >
> >> +&sgx_module {
> >> +    status = "disabled";
> >> +};
> >
> > We should have a separate am3703.dtsi or whatever the SoC model
> > disabling sgx if not there on the SoC. That way board specific
> > dts files can just include it without having to debug this issue
> > over and over.
>
> Thanks for the quick review in that time of the year!
> The sgx issue came up in newer kernels and I had to bisect it to 3b72fc895a2e57f70276b46f386f35d752adf555
> The device just wasn't booting without a message, so yes, we should make it easier for others to figure it out.
> SoC is DM3725 and only DM3730 has sgx support. And it's hard to say if the base is am37xx or omap36xx.
> But I see the reasons you picked am3703, so I would move everything from omap36xx.dtsi to am3703.dtsi except sgx?

> And then include am3703.dtsi in omap36xx.dtsi before sgx support?

I can see value in having a 3703 base and including that in the 36xx
with SGX and DSP nodes, but why not jus make SGX disabled by default.
Those who want/need it can enable it on a per-board basis.
> Or would it be better to have sgx support in a separate dtsi?

I am not sure how much DSP stuff is in there, but the DM3730 is the
AM3703 + DSP and 3D.

adam
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives