linux-kernel - Re: f2fs compile problem in next-20191220 on x86-32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191225130456.GA18929@duo.ucw.cz>
Date:   Wed, 25 Dec 2019 14:04:56 +0100
From:   Pavel Machek <pavel@....cz>
To:     jaegeuk@...nel.org, yuchao0@...wei.com,
        linux-f2fs-devel@...ts.sourceforge.net,
        kernel list <linux-kernel@...r.kernel.org>,
        sfr@...b.auug.org.au, david@...t.cz
Subject: Re: f2fs compile problem in next-20191220 on x86-32

On Sun 2019-12-22 16:49:17, Pavel Machek wrote:
> Hi!
> 
> I'm getting this:
> 
>   LD      .tmp_vmlinux1
>   ld: fs/f2fs/file.o: in function `f2fs_truncate_blocks':
>   file.c:(.text+0x2968): undefined reference to `__udivdi3'
>   make: *** [Makefile:1079: vmlinux] Error 1
> 
> when attempting to compile kernel for x86-32.

David bisected it:

https://bugzilla.kernel.org/show_bug.cgi?id=205967

And the bug is actually easy to see:

+int f2fs_truncate_blocks(struct inode *inode, u64 from, bool lock)
+{
+       u64 free_from = from;
+
+       /*
+        * for compressed file, only support cluster size
+        * aligned truncation.
+        */
+       if (f2fs_compressed_file(inode)) {
+               size_t cluster_size = PAGE_SIZE <<
+                                       F2FS_I(inode)->i_log_cluster_size;
+
+               free_from = roundup(from, cluster_size);

#define roundup(x, y) (                                 \
{                                                       \
        typeof(y) __y = y;                              \
        (((x) + (__y - 1)) / __y) * __y;                \
}                                                       \

div64 is needed instead of div in the roundup macro. Or actually... It
is quite stupid to use roundup like this on value that is power of
two, right?

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)