linux-kernel - Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191225174527.GB27497@sirena.org.uk>
Date:   Wed, 25 Dec 2019 17:45:27 +0000
From:   Mark Brown <broonie@...nel.org>
To:     jeff_chang(張世佳) <jeff_chang@...htek.com>
Cc:     Jeff Chang <richtek.jeff.chang@...il.com>,
        "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "perex@...ex.cz" <perex@...ex.cz>,
        "tiwai@...e.com" <tiwai@...e.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver

On Wed, Dec 25, 2019 at 01:45:43AM +0000, jeff_chang(張世佳) wrote:

> This is adau1997 driver on upstream branch

> @ sound/soc/codecs/adau1997.c

> // SPDX-License-Identifier: GPL-2.0-only
> /*
>  * ADAU1977/ADAU1978/ADAU1979 driver

This is the result of an automatic conversion which wasn't
reviewed, it's not ideal.

> It seems not whole comment use c++. Only first line at source file, Right?

Please do it like this:

// SPDX-License-Identifier: GPL-2.0-only
//
// ADAU1977/ADAU1978/ADAU1979 driver

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)