linux-kernel - Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1577259276.13056.54.camel@mtkswgap22>
Date:   Wed, 25 Dec 2019 15:34:36 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Alim Akhtar <alim.akhtar@...il.com>
CC:     "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Leon Chen (陳文鏘) 
        <Leon.Chen@...iatek.com>,
        "Andy Teng ( .$B{}G!9(.(B)" 
        <Andy.Teng@...iatek.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Chun-Hung Wu (巫駿宏) 
        <Chun-hung.Wu@...iatek.com>,
        Kuohong Wang (王國鴻) 
        <kuohong.wang@...iatek.com>,
        open list <linux-kernel@...r.kernel.org>,
        "Avri Altman" <avri.altman@....com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Peter Wang (王信友) 
        <peter.wang@...iatek.com>, Alim Akhtar <alim.akhtar@...sung.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Pedro Sousa <pedrom.sousa@...opsys.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Bean Huo (beanhuo)" <beanhuo@...ron.com>
Subject: Re: [PATCH v2 1/2 RESEND] soc: mediatek: add header for SiP service
 interface

Hi Alim,

Would you think below explanation is OK to you?

BTW, FYI, this series was combined to the new series "scsi: ufs: add
MediaTek vendor implementations" with this same patch in it.

Thanks,
Stanley


On Fri, 2019-12-20 at 09:15 +0800, Stanley Chu wrote:
> Hi Alim,
> 
> On Fri, 2019-12-20 at 02:00 +0800, Alim Akhtar wrote:
> > > +/* UFS related SMC call */
> > > +#define MTK_SIP_UFS_CONTROL \
> > > +       MTK_SIP_SMC_CMD(0x276)
> > > +
> > How about moving UFS specific stuff to MTK UFS driver and include this
> > header in driver file?
> > Rest looks fine.
> 
> Thanks so much for your review.
> 
> Our intention is to collect all SMC call command types in MediaTek
> Chipsets here for easier management.
> 
> This is the first time we show this header thus only UFS related stuff
> is present here.
> 
> > > +#endif
> > > --
> > > 2.18.0
> > 
> > 
> 
> Thanks,
> Stanley
>