linux-kernel - Re: [PATCH] scsi: don't memset to zero after dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68771eb5-03c4-422b-9956-930a0e3c9de8@cogentembedded.com>
Date:   Thu, 26 Dec 2019 14:16:58 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     "yukuai (C)" <yukuai3@...wei.com>, ysato@...rs.sourceforge.jp,
        dalias@...c.org, aacraid@...rosemi.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, sathya.prakash@...adcom.com,
        chaitra.basappa@...adcom.com, suganath-prabu.subramani@...adcom.com
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, MPT-FusionLinux.pdl@...adcom.com,
        zhengbin13@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH] scsi: don't memset to zero after dma_alloc_coherent

On 26.12.2019 14:13, yukuai (C) wrote:

>>> dma_alloc_coherent already zeros out memory, so memset to zero is not
>>> needed.
>>>
>>> Signed-off-by: yu kuai <yukuai3@...wei.com>
>>> ---
>>>   arch/sh/mm/consistent.c             | 2 --
>>
>>     How this one is related to SCSI?
>>
> Thank you for your response!
> I put them in the same patch because I thougt they are the same situation. I'm 
> sorry if it's not appropriate.

    I'd recommend to split such patch to (at least) different subsystems, e.g. 
arch/sh/ part, drivers/scsi/ part.

> Yu Kuai

MBR, Sergei