linux-kernel - Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5744632b88b44369a68c0b0704bfb48e@huawei.com>
Date:   Thu, 26 Dec 2019 02:31:27 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Liran Alon <liran.alon@...cle.com>
CC:     "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault
 injected

Hi,

Liran Alon <liran.alon@...cle.com> wrote:
>> On 25 Dec 2019, at 4:21, linmiaohe <linmiaohe@...wei.com> wrote:
>> 
>> From: Miaohe Lin <linmiaohe@...wei.com>
>> 
>> We should retry writing guest memory when 
>> kvm_write_guest_virt_system() failed and page fault is injected in handle_vmread().
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>
>Patch fix seems correct to me:
>Reviewed-by: Liran Alon <liran.alon@...cle.com>

Thanks for your review.

>However, I suggest to rephrase commit title & message as follows:
>
>"""
>KVM: nVMX: vmread should not set rflags to specify success in case of #PF
>
>In case writing to vmread destination operand result in a #PF, vmread should not call nested_vmx_succeed() to set rflags to specify success. Similar to as done in for VMPTRST (See handle_vmptrst()).
>"""

Thanks for your sueestion, I would rephrase commit title & message accordingly.

>
>In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.

I'd like to submit kvm-unit-test that verifies this condition, but I am not familiar with the kvm-unit-test code yet and
also not in my recent todo list. So such a patch may come late. It would be appreciated too if you could submit this
kvm-unit-test patch. :) 
Thanks again.