linux-kernel - Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 26 Dec 2019 03:09:23 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Wanpeng Li <kernellwp@...il.com>
CC:     Liran Alon <liran.alon@...cle.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>,
        "sean.j.christopherson@...el.com" <sean.j.christopherson@...el.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "wanpengli@...cent.com" <wanpengli@...cent.com>,
        "jmattson@...gle.com" <jmattson@...gle.com>,
        "joro@...tes.org" <joro@...tes.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>, "hpa@...or.com" <hpa@...or.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault
 injected

Hi,

Wanpeng Li <kernellwp@...il.com> wrote:
> On Thu, 26 Dec 2019 at 10:32, linmiaohe <linmiaohe@...wei.com> wrote:
> >
> > >
> > >In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.
> >
> > I'd like to submit kvm-unit-test that verifies this condition, but I 
> > am not familiar with the kvm-unit-test code yet and also not in my 
> > recent todo list. So such a patch may come late. It would be 
> > appreciated too if you could submit this kvm-unit-test patch. :)
>
> Hmm, did you verify your own patch? Please give the testcase.
>

I'am sorry but this is a code inspection path. And I think this fix is correct from the code logic and
this behavior is similar as handle_vmwrite, handle_vmptrst, handle_invept and so on. Thanks!