linux-kernel - Re: [net-next] enetc: add support time specific departure base on the qos etf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191226.150941.618022568387879445.davem@davemloft.net>
Date:   Thu, 26 Dec 2019 15:09:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     po.liu@....com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        vinicius.gomes@...el.com, claudiu.manoil@....com,
        vladimir.oltean@....com, alexandru.marginean@....com,
        xiaoliang.yang_1@....com, roy.zang@....com, mingkai.hu@....com,
        jerry.huang@....com, leoyang.li@....com, ivan.khoronzhuk@...aro.org
Subject: Re: [net-next] enetc: add support time specific departure base on
 the qos etf

From: Po Liu <po.liu@....com>
Date: Mon, 23 Dec 2019 03:42:39 +0000

> - Transmit checksum offloads and time specific departure operation
> are mutually exclusive.

I do not see anything which enforces this conflict.

It looks to me like if the user configures time specific departure,
and TX SKBs will be checksum offloaded, the time specific departure
will simply not be performed.

If true, this behavior will be very surprising for the user.

Instead, the configuration operation that creates the conflict should
throw and error and fail.

Thank you.