linux-kernel - Re: [PATCH] powerpc/shared: Fix build problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191226035505.GB1781@linux.vnet.ibm.com>
Date:   Thu, 26 Dec 2019 09:25:05 +0530
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Phil Auld <pauld@...hat.com>, Waiman Long <longman@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH] powerpc/shared: Fix build problem

* Guenter Roeck <linux@...ck-us.net> [2019-12-25 08:06:26]:

> Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
> shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
> processors as non-preempt"), powerpc test builds may fail with the
> following build errors.
> 
> ./arch/powerpc/include/asm/spinlock.h:39:1: error:
> 	type defaults to ???int??? in declaration of ???DECLARE_STATIC_KEY_FALSE???
> ./arch/powerpc/include/asm/spinlock.h: In function ???vcpu_is_preempted???:
> ./arch/powerpc/include/asm/spinlock.h:44:7: error:
> 	implicit declaration of function ???static_branch_unlikely???
> ./arch/powerpc/include/asm/spinlock.h:44:31: error:
> 	???shared_processor??? undeclared
> 
> The offending commits use static_branch_unlikely and shared_processor
> without adding the include file declaring it.

Thanks for reporting but same fix was already posted
http://lkml.kernel.org/r/20191223133147.129983-1-Jason@zx2c4.com


-- 
Thanks and Regards
Srikar Dronamraju