linux-kernel - Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0e0f983-1284-b641-0d74-bc4f49ef1d80@codeaurora.org>
Date:   Thu, 26 Dec 2019 11:26:25 +0530
From:   "Sandeep Maheswaram (Temp)" <sanm@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Felipe Balbi <balbi@...nel.org>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-usb@...r.kernel.org,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        Manu Gautam <mgautam@...eaurora.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3
 bindings

Hi

On 12/18/2019 12:44 AM, Doug Anderson wrote:
> Hi,
>
> On Sun, Dec 15, 2019 at 9:40 PM Sandeep Maheswaram <sanm@...eaurora.org> wrote:
>>
>>
>> +    items:
>> +      - description: System Config NOC clock. Not present on "qcom,msm8996-dwc3" compatible.
>> +      - description: Master/Core clock, have to be >= 125 MHz for SS operation and >= 60MHz for HS operation
> To make the grammer gooder, s/have/has/
>
>
>> +      - description: System bus AXI clock. Not present on "qcom,msm8996-dwc3" compatible.
>> +      - description: Mock utmi clock needed for ITP/SOF generation in host mode.Its frequency should be 19.2MHz.
>> +      - description: Sleep clock, used for wakeup when USB3 core goes into low power mode (U3).
> * Please word wrap to ~80 chracters.
> * As Stephen says, order matters.  Please match order of old bindings
> (and in clock-names)
> * Please end each with a period.

Regarding the order of clocks, If I change the order  I am facing error 
in make dtbs_check

linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@...8800: 
clock-names:0: 'core' was expected
linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@...8800: 
clock-names:1: 'mock_utmi' was expected
linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@...8800: 
clock-names:2: 'sleep' was expected
linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@...8800: 
clock-names:3: 'cfg_noc' was expected
linux-next/arch/arm64/boot/dts/qcom/sc7180-idp.dt.yaml: usb@...8800: 
clock-names:4: 'iface' was expected

Need to modify in the sc7180.dtsi and sdm845.dtsi  to avoid the error  . 
Please let me know how to proceed.

>
>
>> +  clock-names:
>> +    minItems: 3
>> +    items:
>> +      - const: cfg_noc
>> +      - const: core
>> +      - const: iface
>> +      - const: mock_utmi
>> +      - const: sleep
>> +
>>
>
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation