lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Dec 2019 17:21:28 +0800 From: Xinwei Kong <kong.kongxinwei@...ilicon.com> To: <broonie@...nel.org>, <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: <linuxarm@...wei.com>, Xinwei Kong <kong.kongxinwei@...ilicon.com>, fengsheng <fengsheng5@...wei.com> Subject: [PATCH] spi: dw: use "smp_mb()" to avoid sending spi data error this patch will add memory barrier to ensure this "struct dw_spi *dws" to complete data setting before enabling this SPI hardware interrupt. eg: it will fix to this following low possibility error in testing environment which using SPI control to connect TPM Modules kernel: tpm tpm0: Operation Timed out kernel: tpm tpm0: tpm_relinquish_locality: : error -1 Signed-off-by: fengsheng <fengsheng5@...wei.com> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com> --- drivers/spi/spi-dw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index a92aa5c..d0d77a2 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -288,6 +288,8 @@ static int dw_spi_transfer_one(struct spi_controller *master, dws->rx_end = dws->rx + transfer->len; dws->len = transfer->len; + smp_mb(); + spi_enable_chip(dws, 0); /* Handle per transfer options for bpw and speed */ -- 2.7.4
Powered by blists - more mailing lists