linux-kernel - Re: [PATCH] use bash instead of sh to run mkcompile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAS7Jj0=abxAH4K41BkBfrOLjygBo0KvXyVUO2b240bCww@mail.gmail.com>
Date:   Thu, 26 Dec 2019 18:25:12 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Liangcai Fan <fanliangcai9@...il.com>
Cc:     Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        zhang.lyra@...il.com, gengcixi@...il.com, orson.zhai@...soc.com,
        Liangcai Fan <liangcai.fan@...soc.com>
Subject: Re: [PATCH] use bash instead of sh to run mkcompile_h

On Wed, Dec 25, 2019 at 2:58 PM Liangcai Fan <fanliangcai9@...il.com> wrote:
>
> From: Liangcai Fan <liangcai.fan@...soc.com>
>
> Use sh to run mkcompile_h, compilation would fail if whoami contains
> backslash, since sh uses dash. The reason is that the echo command would
> interpret backslash to escapes, so the LINUX_COMPILE_BY definition was
> incorrect.
>
> Parse mkcompile_h with bash, the echo command would not see backslash as
> escapes, then there is no error with the definition of LINUX_COMPILE_BY.
>
> Signed-off-by: Liangcai Fan <liangcai.fan@...soc.com>
> Signed-off-by: Liangcai Fan <fanliangcai9@...il.com>
> ---

This problem was fixed by
commit c8f3dea90e38194dae542c5d56e05d30447e58cb



-- 
Best Regards
Masahiro Yamada