linux-kernel - [PATCH] PCI/PM: Report runtime wakeup is not supported if bridge isn't bound to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191227092405.29588-1-kai.heng.feng@canonical.com>
Date:   Fri, 27 Dec 2019 17:24:05 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     bhelgaas@...gle.com, rafael.j.wysocki@...el.com
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kai-Heng Feng <kai.heng.feng@...onical.com>
Subject: [PATCH] PCI/PM: Report runtime wakeup is not supported if bridge isn't bound to driver

We have a Pericom USB add-on card that has three USB controller
functions 06:00.[0-2], connected to bridge device 05:03.0, which is
connected to another bridge device 04:00.0:

-[0000:00]-+-00.0
           +-1c.6-[04-06]----00.0-[05-06]----03.0-[06]--+-00.0
           |                                            +-00.1
           |                                            \-00.2

When bridge device (05:03.0) and all three USB controller functions
(06:00.[0-2]) are runtime suspended, they don't get woken up by plugging
USB devices into the add-on card.

This is because the pcieport driver failed to probe on 04:00.0, since
the device supports neither legacy IRQ, MSI nor MSI-X. Because of that,
there's no native PCIe PME can work for devices connected to it.

So let's correctly report runtime wakeup isn't supported when any of
PCIe bridges isn't bound to pcieport driver.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205981
Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
---
 drivers/pci/pci.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 951099279192..ca686cfbd65e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -2493,6 +2493,18 @@ bool pci_dev_run_wake(struct pci_dev *dev)
 	if (!pci_pme_capable(dev, pci_target_state(dev, true)))
 		return false;
 
+	/* If any upstream PCIe bridge isn't bound to pcieport driver, there's
+	 * no IRQ for PME.
+	 */
+	if (pci_is_pcie(dev)) {
+		while (bus->parent) {
+			if (!bus->self->driver)
+				return false;
+
+			bus = bus->parent;
+		}
+	}
+
 	if (device_can_wakeup(&dev->dev))
 		return true;
 
-- 
2.17.1