linux-kernel - Re: [PATCH] board-dm644x-evm: fix 2 missing-check bugs in evm_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191227160142.GW25745@shell.armlinux.org.uk>
Date:   Fri, 27 Dec 2019 16:01:42 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Gen Zhang <blackgod016574@...il.com>
Cc:     nsekhar@...com, bgolaszewski@...libre.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] board-dm644x-evm: fix 2 missing-check bugs in
 evm_led_setup()

On Fri, Dec 27, 2019 at 10:39:21AM +0800, Gen Zhang wrote:
> In evm_led_setup(), the allocation result of platform_device_alloc() and 
> platform_device_add_data() should be checked.
> 
> Signed-off-by: Gen Zhang <blackgod016574@...il.com>
> ---
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> index 9d87d4e..9cd2785 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -352,15 +352,20 @@ evm_led_setup(struct i2c_client *client, int gpio, unsigned ngpio, void *c)
>  	 * device unregistration ...
>  	 */
>  	evm_led_dev = platform_device_alloc("leds-gpio", 0);
> -	platform_device_add_data(evm_led_dev,
> +	if (!evm_led_dev)
> +		return -ENOMEM;
> +	status = platform_device_add_data(evm_led_dev,
>  			&evm_led_data, sizeof evm_led_data);
> +	if (status)
> +		goto err;
>  
>  	evm_led_dev->dev.parent = &client->dev;
>  	status = platform_device_add(evm_led_dev);
> -	if (status < 0) {
> -		platform_device_put(evm_led_dev);
> -		evm_led_dev = NULL;
> -	}
> +	if (status)
> +		goto err;
> +err:
> +	platform_device_put(evm_led_dev);
> +	evm_led_dev = NULL;

Please look again at the above change very closely. You will want to
send an updated patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up