linux-kernel - Re: [PATCH v4 1/5] dt-bindings: arm: fsl: Add Gateworks Ventana i.MX6DL/Q compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5Aj+PfzXrYoV8LxKStdQ-B0BLdMV16L3ya0NokozG479g@mail.gmail.com>
Date:   Thu, 26 Dec 2019 21:34:06 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Robert Jones <rjones@...eworks.com>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v4 1/5] dt-bindings: arm: fsl: Add Gateworks Ventana
 i.MX6DL/Q compatibles

Hi Rob,

On Thu, Dec 26, 2019 at 8:26 PM Rob Herring <robh@...nel.org> wrote:
>
> On Mon, Dec 23, 2019 at 05:00:16PM -0800, Robert Jones wrote:
> > Add the compatible enum entries for Gateworks Ventana boards.
> >
> > Signed-off-by: Robert Jones <rjones@...eworks.com>
> > ---
> >  Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index f79683a..a02e980 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -126,6 +126,7 @@ properties:
> >                - toradex,apalis_imx6q-ixora      # Apalis iMX6 Module on Ixora
> >                - toradex,apalis_imx6q-ixora-v1.1 # Apalis iMX6 Module on Ixora V1.1
> >                - variscite,dt6customboard
> > +              - gw,ventana                # Gateworks i.MX6DL or i.MX6Q Ventana
>
> Keep entries sorted.

Just for clarification: shouldn't the entries inside fsl.yaml match
the dtb file names?

In case of the i.MX6Q based gateworks board, this should be:

gw,imx6q-gw51xx
gw,imx6q-gw52xx
gw,imx6q-gw53xx
gw,imx6q-gw5400-a
gw,imx6q-gw54xx
gw,imx6q-gw551x
gw,imx6q-gw552x
gw,imx6q-gw553x
gw,imx6q-gw560x
gw,imx6q-gw5903
gw,imx6q-gw5904

Please advise.