linux-kernel - Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Dec 2019 07:09:06 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Christian Bundy <christianbundy@...ction.io>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        stable <stable@...r.kernel.org>, linux-integrity@...r.kernel.org
Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of
 tpm_tis_core_init

On Thu, 2019-12-19 at 03:07 -0700, Jerry Snitselaar wrote:
> > These patches take a usable system and make it unusable:
> > 
> > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
> > 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's
> > 
> > ...they need to be reverted, or the regression needs to be fixed, but
> > asserting that you fixed something else unrelated does not help.
> > 
> 
> Reverting 1ea32c83c699 ("tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before
> probing for interrupts") would at least allow people impacted by this
> to boot their systems without disabling the tpm, or blacklisting the
> module while we figure this out. From what I can tell the tpm_tis code
> was operating in that state since 570a36097f30 ("tpm: drop 'irq' from
> struct tpm_vendor_specific") until Stefan's patch.

I'll formalize a fix based on the reverts.

Sorry for the holiday latency.

/Jarkko