linux-kernel - Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29610962-92d4-2989-f18c-fa4a0a13ccb4@web.de>
Date:   Sat, 28 Dec 2019 20:50:07 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>, linux-rdma@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Doug Ledford <dledford@...hat.com>,
        Faisal Latif <faisal.latif@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Kangjie Lu <kjlu@....edu>,
        Leon Romanovsky <leon@...nel.org>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer
 dereference

> in_dev_get may return a NULL object.

I would prefer a wording like “A null pointer can be returned by in_dev_get().”.


> The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.

How do you think about the wording suggestion “Thus add a corresponding check
so that a null pointer dereference will be avoided at this place.”?

Please add also the tag “Fixes” to your change description.

Regards,
Markus