linux-kernel - Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0db93c30-2c87-9824-31be-a15c0d141ab5@web.de>
Date:   Sat, 28 Dec 2019 21:45:52 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     yu kuai <yukuai3@...wei.com>, dri-devel@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>, Eric Anholt <eric@...olt.net>,
        Yi Zhang <yi.zhang@...wei.com>,
        zhengbin <zhengbin13@...wei.com>
Subject: Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

> v3d_submit_cl_ioctl call kfree() with variable 'bin' twice.

I would prefer a wording like “kfree() was called for the same variable twice
within an if branch.”.


> Fix it by removing the latter one.

I find the wording “Delete a duplicate function call.” more appropriate.

Please add the tag “Fixes” to your change description.

Regards,
Markus