[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191228034921.GG15663@cisco>
Date: Fri, 27 Dec 2019 20:49:21 -0700
From: Tycho Andersen <tycho@...ho.ws>
To: Sargun Dhillon <sargun@...gun.me>
Cc: linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
jannh@...gle.com, christian.brauner@...ntu.com,
keescook@...omium.org, cyphar@...har.com
Subject: Re: [PATCH v2 2/2] seccomp: Check that seccomp_notif is zeroed out
by the user
On Sat, Dec 28, 2019 at 01:48:51AM +0000, Sargun Dhillon wrote:
> This patch is a small change in enforcement of the uapi for
> SECCOMP_IOCTL_NOTIF_RECV ioctl. Specifically, the datastructure which
> is passed (seccomp_notif) must be zeroed out. Previously any of its
> members could be set to nonsense values, and we would ignore it.
>
> This ensures all fields are set to their zero value.
>
> This relies on the seccomp_notif datastructure to not have
> any unnamed padding, as it is valid to initialize the datastructure
> as:
>
> struct seccomp_notif notif = {};
>
> This only initializes named members to their 0-value [1].
>
> [1]: https://lore.kernel.org/lkml/20191227023131.klnobtlfgeqcmvbb@yavin.dot.cyphar.com/
>
> Signed-off-by: Sargun Dhillon <sargun@...gun.me>
Acked-by: Tycho Andersen <tycho@...ho.ws>
Powered by blists - more mailing lists