lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Dec 2019 22:04:09 -0800 (PST) From: Paul Walmsley <paul.walmsley@...ive.com> To: Luc Van Oostenryck <luc.vanoostenryck@...il.com> cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, kbuild test robot <lkp@...el.com>, Christoph Hellwig <hch@....de>, Palmer Dabbelt <palmer@...belt.com> Subject: Re: [PATCH] riscv: fix compile failure with EXPORT_SYMBOL() & !MMU On Sun, 22 Dec 2019, Luc Van Oostenryck wrote: > When support for !MMU was added, the declaration of > __asm_copy_to_user() & __asm_copy_from_user() were #ifdefed > out hence their EXPORT_SYMBOL() give an error message like: > .../riscv_ksyms.c:13:15: error: '__asm_copy_to_user' undeclared here > .../riscv_ksyms.c:14:15: error: '__asm_copy_from_user' undeclared here > > Since these symbols are not defined with !MMU it's wrong to export them. > Same for __clear_user() (even though this one is also declared in > include/asm-generic/uaccess.h and thus doesn't give an error message). > > Fix this by doing the EXPORT_SYMBOL() directly where these symbols > are defined: inside lib/uaccess.S itself. > > Fixes 6bd33e1ece528f67646db33bf97406b747dafda0 > Reported-by: kbuild test robot <lkp@...el.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Palmer Dabbelt <palmer@...belt.com> > Cc: Paul Walmsley <paul.walmsley@...ive.com> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com> Thanks Luc; queued for v5.5-rc. - Paul
Powered by blists - more mailing lists