linux-kernel - Re: nvmem: core: Checking the decrementing of reference counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a95fa07-dfae-54ef-9d19-682bace02e5f@web.de>
Date:   Sat, 28 Dec 2019 13:25:49 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xu Wang <vulab@...as.ac.cn>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: nvmem: core: Checking the decrementing of reference counters

I have taken another look at the implementation of the function “nvmem_device_release”.
https://elixir.bootlin.com/linux/v5.5-rc3/source/drivers/nvmem/core.c#L421
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nvmem/core.c?id=bf8d1cd4386535004c4afe7f03d37f9864c9940e#n421

Now I wonder why the statement “put_device(&nvmem->dev)” is performed here
after it was also executed by the function “__nvmem_device_put” before.
How often should the device reference count be decremented (at the end)?

Regards,
Markus