linux-kernel - Re: [PATCH v3] Staging: wfx: Fix style issues with hif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ec873d6df7de91c972fa356eb33d65437a3e67b.camel@perches.com>
Date:   Sun, 29 Dec 2019 14:51:58 -0800
From:   Joe Perches <joe@...ches.com>
To:     Matthew Hanzelik <mrhanzelik@...il.com>,
        jerome.pouiller@...abs.com, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Staging: wfx: Fix style issues with hif_rx.c

On Sun, 2019-12-29 at 17:31 -0500, Matthew Hanzelik wrote:
> Fix the 80 line limit warning on line 79 of hif_rx.c.
> 
> Also fixes the missing blank line warning on line 305 of hif_rx.c after
> the declaration of size_t len.
[]
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
[]
> @@ -76,7 +76,8 @@ static int hif_multi_tx_confirm(struct wfx_dev *wdev, struct hif_msg *hif,
>  				void *buf)
>  {
>  	struct hif_cnf_multi_transmit *body = buf;
> -	struct hif_cnf_tx *buf_loc = (struct hif_cnf_tx *) &body->tx_conf_payload;
> +	struct hif_cnf_tx *buf_loc =
> +		(struct hif_cnf_tx *) &body->tx_conf_payload;

Just get rid of the cast instead

	struct hif_cnf_tx *buf_loc = body->tx_conf_payload;

should work fine.