linux-kernel - Re: [PATCH linux-can/testing] can: tcan4x5x: Disable the INH pin device-state GPIO is unavailable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afa5c681-bbd1-a6f6-2b58-4f24c924144e@pengutronix.de>
Date:   Sun, 29 Dec 2019 17:05:47 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Dan Murphy <dmurphy@...com>, linux-kernel@...r.kernel.org,
        linux-can@...r.kernel.org, wg@...ndegger.com,
        sriram.dash@...sung.com
Subject: Re: [PATCH linux-can/testing] can: tcan4x5x: Disable the INH pin
 device-state GPIO is unavailable

On 12/29/19 4:32 PM, Marc Kleine-Budde wrote:
> On 12/12/19 5:15 PM, Dan Murphy wrote:
>>  static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>  {
>>  	struct tcan4x5x_priv *tcan4x5x = cdev->device_data;
>> @@ -383,8 +393,10 @@ static int tcan4x5x_parse_config(struct m_can_classdev *cdev)
>>  	tcan4x5x->device_state_gpio = devm_gpiod_get_optional(cdev->dev,
>>  							      "device-state",
>>  							      GPIOD_IN);
>> -	if (IS_ERR(tcan4x5x->device_state_gpio))
>> +	if (IS_ERR(tcan4x5x->device_state_gpio)) {
>>  		tcan4x5x->device_state_gpio = NULL;
>> +		tcan4x5x_disable_state(cdev);
>> +	}
> For some reason, this hunk doesn't apply, due to the additional:
> 
>>> 	tcan4x5x->power = devm_regulator_get_optional(cdev->dev,
>>> 						      "vsup");

...which was my fault. :) Please have a look at

https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git/log/?h=testing

...if I've collected every m_can related patch.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)