lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 28 Dec 2019 19:35:30 -0800 From: Bjorn Andersson <bjorn.andersson@...aro.org> To: Sricharan R <sricharan@...eaurora.org> Cc: agross@...nel.org, devicetree@...r.kernel.org, linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, linux-soc@...r.kernel.org, robh+dt@...nel.org, sboyd@...nel.org, sivaprak@...eaurora.org Subject: Re: [PATCH V2 2/7] pinctrl: qcom: Add ipq6018 pinctrl driver On Thu 19 Dec 02:41 PST 2019, Sricharan R wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq6018.c b/drivers/pinctrl/qcom/pinctrl-ipq6018.c [..] > +static const struct msm_function ipq6018_functions[] = { [..] > + FUNCTION(qpic_pad), > + FUNCTION(qpic_pad0), > + FUNCTION(qpic_pad1), > + FUNCTION(qpic_pad2), > + FUNCTION(qpic_pad3), > + FUNCTION(qpic_pad4), > + FUNCTION(qpic_pad5), > + FUNCTION(qpic_pad6), > + FUNCTION(qpic_pad7), > + FUNCTION(qpic_pad8), Shouldn't the qpic_padN entries be removed now? (Please double check the rest as well) [..] > + > +static const struct msm_pingroup ipq6018_groups[] = { > + PINGROUP(0, qpic_pad, wci20, qdss_traceclk_b, _, burn0, _, _, _, _), > + PINGROUP(1, qpic_pad, mac12, qdss_tracectl_b, _, burn1, _, _, _, _), > + PINGROUP(2, qpic_pad, wci20, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(3, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(4, qpic_pad, mac01, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(5, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(6, qpic_pad, mac21, qdss_tracedata_b, _, _, _, _, _, _), > + PINGROUP(7, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(8, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(9, qpic_pad, atest_char, cxc0, mac13, dbg_out, qdss_tracedata_b, _, _, _), > + PINGROUP(10, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(11, qpic_pad, wci22, mac12, qdss_tracedata_b, _, _, _, _, _), > + PINGROUP(12, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(13, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(14, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(15, qpic_pad, qdss_tracedata_b, _, _, _, _, _, _, _), > + PINGROUP(16, qpic_pad, cxc0, mac13, qdss_tracedata_b, _, _, _, _, _), > + PINGROUP(17, qpic_pad, qdss_tracedata_b, wci22, _, _, _, _, _, _), Regards, Bjorn
Powered by blists - more mailing lists