linux-kernel - [PATCH] platform: goldfish: pipe: switch to platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191229104325.10132-2-tiny.windzz@gmail.com>
Date:   Sun, 29 Dec 2019 10:43:24 +0000
From:   Yangtao Li <tiny.windzz@...il.com>
To:     corbet@....net, gregkh@...uxfoundation.org,
        bgolaszewski@...libre.com, arnd@...db.de, sboyd@...nel.org,
        mchehab+samsung@...nel.org, matti.vaittinen@...rohmeurope.com,
        phil.edworthy@...esas.com, suzuki.poulose@....com,
        saravanak@...gle.com, heikki.krogerus@...ux.intel.com,
        dan.j.williams@...el.com, joe@...ches.com,
        jeffrey.t.kirsher@...el.com, mans@...sr.com, tglx@...utronix.de,
        hdegoede@...hat.com, akpm@...ux-foundation.org,
        ulf.hansson@...aro.org, ztuowen@...il.com,
        sergei.shtylyov@...entembedded.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Yangtao Li <tiny.windzz@...il.com>
Subject: [PATCH] platform: goldfish: pipe: switch to platform_get_irq

platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index cef0133aa47a..a1ebaec6eea9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
-		return -EINVAL;
-
-	dev->irq = r->start;
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
+		return dev->irq;
 
 	/*
 	 * Exchange the versions with the host device
-- 
2.17.1