linux-kernel - RE: [PATCH 01/13] mailbox: altera: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR11MB45099287D74F144546CBB6EBCC270@MN2PR11MB4509.namprd11.prod.outlook.com>
Date:   Mon, 30 Dec 2019 01:50:45 +0000
From:   "Tan, Ley Foon" <ley.foon.tan@...el.com>
To:     Yangtao Li <tiny.windzz@...il.com>,
        "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
        "nsaenzjulienne@...e.de" <nsaenzjulienne@...e.de>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "rjui@...adcom.com" <rjui@...adcom.com>,
        "sbranden@...adcom.com" <sbranden@...adcom.com>,
        "bcm-kernel-feedback-list@...adcom.com" 
        <bcm-kernel-feedback-list@...adcom.com>,
        "lftan@...era.com" <lftan@...era.com>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "agross@...nel.org" <agross@...nel.org>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rpi-kernel@...ts.infradead.org" 
        <linux-rpi-kernel@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: RE: [PATCH 01/13] mailbox: altera: convert to
 devm_platform_ioremap_resource



> -----Original Message-----
> From: Yangtao Li <tiny.windzz@...il.com>
> Sent: Sunday, December 29, 2019 2:35 AM
> To: jassisinghbrar@...il.com; nsaenzjulienne@...e.de;
> f.fainelli@...il.com; rjui@...adcom.com; sbranden@...adcom.com; bcm-
> kernel-feedback-list@...adcom.com; lftan@...era.com;
> matthias.bgg@...il.com; agross@...nel.org; bjorn.andersson@...aro.org;
> mcoquelin.stm32@...il.com; alexandre.torgue@...com;
> thierry.reding@...il.com; jonathanh@...dia.com; linux-
> kernel@...r.kernel.org; linux-rpi-kernel@...ts.infradead.org; linux-arm-
> kernel@...ts.infradead.org; nios2-dev@...ts.rocketboards.org; linux-
> mediatek@...ts.infradead.org; linux-arm-msm@...r.kernel.org; linux-
> stm32@...md-mailman.stormreply.com; linux-tegra@...r.kernel.org
> Cc: Yangtao Li <tiny.windzz@...il.com>
> Subject: [PATCH 01/13] mailbox: altera: convert to
> devm_platform_ioremap_resource
> 
> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>

Reviewed-by: Ley Foon Tan <ley.foon.tan@...el.com>

> ---
>  drivers/mailbox/mailbox-altera.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-
> altera.c
> index 75282666fb06..afb320e9d69c 100644
> --- a/drivers/mailbox/mailbox-altera.c
> +++ b/drivers/mailbox/mailbox-altera.c
> @@ -285,7 +285,6 @@ static const struct mbox_chan_ops altera_mbox_ops
> = {  static int altera_mbox_probe(struct platform_device *pdev)  {
>         struct altera_mbox *mbox;
> -       struct resource *regs;
>         struct mbox_chan *chans;
>         int ret;
> 
> @@ -299,9 +298,7 @@ static int altera_mbox_probe(struct platform_device
> *pdev)
>         if (!chans)
>                 return -ENOMEM;
> 
> -       regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -       mbox->mbox_base = devm_ioremap_resource(&pdev->dev, regs);
> +       mbox->mbox_base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(mbox->mbox_base))
>                 return PTR_ERR(mbox->mbox_base);
> 
> --
> 2.17.1
> 
> 
> ________________________________
> 
> Confidentiality Notice.
> This message may contain information that is confidential or otherwise
> protected from disclosure. If you are not the intended recipient, you are
> hereby notified that any use, disclosure, dissemination, distribution, or
> copying of this message, or any attachments, is strictly prohibited. If you
> have received this message in error, please advise the sender by reply e-mail,
> and delete the message and any attachments. Thank you.