linux-kernel - RE: [PATCH 1/2] i3c: dw: convert to devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR12MB4223E00D8862033751A7DEFFAE270@MN2PR12MB4223.namprd12.prod.outlook.com>
Date:   Mon, 30 Dec 2019 13:40:11 +0000
From:   Vitor Soares <Vitor.Soares@...opsys.com>
To:     Yangtao Li <tiny.windzz@...il.com>,
        "bbrezillon@...nel.org" <bbrezillon@...nel.org>,
        "pgaj@...ence.com" <pgaj@...ence.com>
CC:     "linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] i3c: dw: convert to devm_platform_ioremap_resource

Hi Yangtao,

Thanks for your patch.

From: Yangtao Li <tiny.windzz@...il.com>
Date: Sat, Dec 28, 2019 at 18:54:05

> Use devm_platform_ioremap_resource() to simplify code.
> 
> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> ---
>  drivers/i3c/master/dw-i3c-master.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index b0ff0e12d84c..7b941e93337f 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1100,15 +1100,13 @@ static const struct i3c_master_controller_ops dw_mipi_i3c_ops = {
>  static int dw_i3c_probe(struct platform_device *pdev)
>  {
>  	struct dw_i3c_master *master;
> -	struct resource *res;
>  	int ret, irq;
>  
>  	master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
>  	if (!master)
>  		return -ENOMEM;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	master->regs = devm_ioremap_resource(&pdev->dev, res);
> +	master->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(master->regs))
>  		return PTR_ERR(master->regs);
>  
> -- 
> 2.17.1

Acked-by: Vitor Soares <vitor.soares@...opsys.com>

Best regards,
Vitor 
Soares