linux-kernel - Re: [PATCH -next] PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGTfZH34ufvwco8w6GN8E=KUuSeCfjFk4bR7PnotbLso0UNzoA@mail.gmail.com>
Date:   Tue, 31 Dec 2019 03:08:53 +0900
From:   Chanwoo Choi <chanwoo@...nel.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Shawn Guo <shawnguo@...nel.org>, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com,
        dl-linux-imx <linux-imx@....com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] PM / devfreq: imx8m-ddrc: Fix inconsistent IS_ERR
 and PTR_ERR

On Tue, Dec 31, 2019 at 2:35 AM Chanwoo Choi <chanwoo@...nel.org> wrote:
>
> On Mon, Dec 30, 2019 at 5:58 PM YueHaibing <yuehaibing@...wei.com> wrote:
> >
> > Fix inconsistent IS_ERR and PTR_ERR in imx8m_ddrc_probe().
> > Detected using Coccinelle.
> >
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  drivers/devfreq/imx8m-ddrc.c | 24 ++++++++++++++++++------
> >  1 file changed, 18 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> > index 53df792..bc82d36 100644
> > --- a/drivers/devfreq/imx8m-ddrc.c
> > +++ b/drivers/devfreq/imx8m-ddrc.c
> > @@ -395,15 +395,27 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> >         }
> >
> >         priv->dram_core = devm_clk_get(dev, "core");
> > +       if (IS_ERR(priv->dram_core)) {
> > +               ret = PTR_ERR(priv->dram_core);
> > +               dev_err(dev, "failed to fetch core clock: %d\n", ret);
>
> If there is no special reason, just use 'get' instead of ' fetch' word.
> s/fetch/get

Usually, use 'verb' included in function name to show the debug message.
But, Again thinking. the original comment used 'fetch' word. Please
ignore my comment

Applied it.

(snip)

Best Regards,
Chanwoo Choi