linux-kernel - Re: [PATCH v2] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Dec 2019 11:12:46 +0800
From:   Chris Chiu <chiu@...lessm.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     perex@...ex.cz, tiwai@...e.com, Kailang <kailang@...ltek.com>,
        Hui Wang <hui.wang@...onical.com>, tomas.espeleta@...il.com,
        alsa-devel@...a-project.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Upstreaming Team <linux@...lessm.com>,
        Jian-Hong Pan <jian-hong@...lessm.com>
Subject: Re: [PATCH v2] ALSA: hda/realtek - Enable the bass speaker of ASUS UX431FLC

On Sat, Dec 28, 2019 at 4:05 PM Takashi Iwai <tiwai@...e.de> wrote:
>
> On Fri, 27 Dec 2019 11:08:25 +0100,
> Chris Chiu wrote:
> >
> > ASUS reported that there's an bass speaker in addition to internal
> > speaker and it uses DAC 0x02. It was not enabled in the commit
> > 436e25505f34 ("ALSA: hda/realtek - Enable internal speaker of ASUS
> > UX431FLC") which only enables the amplifier for the front speaker.
> > This commit enables the bass speaker on top of the aforementioned
> > work to improve the acoustic experience.
> >
> > Signed-off-by: Chris Chiu <chiu@...lessm.com>
> > Signed-off-by: Jian-Hong Pan <jian-hong@...lessm.com>
> > ---
> >
> > Notes:
> >   v2:
> >    - Use existing alc285_fixup_speaker2_to_dac1 instead of new fixup function
> >    - Correct the commit hash number in the commit message
> >    - Remove the redundant fixup ALC294_FIXUP_ASUS_INTSPK_HEADSET_MIC
>
> Could you rebase on the latest for-linus branch?  This patch isn't
> applied cleanly any longer.
>
>
> thanks,
>
> Takashi

Got it. I'll prepare a v3 to rebase on latest for-lnus.

Chris