linux-kernel - Re: [net-next PATCH] net/ncsi: Fix gma flag setting after response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18C0CEBF-04F1-4597-911A-3C55C09FA15E@fb.com>
Date:   Mon, 30 Dec 2019 19:22:40 +0000
From:   Vijay Khemka <vijaykhemka@...com>
To:     Samuel Mendoza-Jonas <sam@...dozajonas.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "joel@....id.au" <joel@....id.au>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        Sai Dasari <sdasari@...com>
Subject: Re: [net-next PATCH] net/ncsi: Fix gma flag setting after response



On 12/28/19, 9:58 AM, "Samuel Mendoza-Jonas" <sam@...dozajonas.com> wrote:

    On Fri, 2019-12-27 at 14:43 -0800, Vijay Khemka wrote:
    > gma_flag was set at the time of GMA command request but it should
    > only be set after getting successful response. Movinng this flag
    > setting in GMA response handler.
    > 
    > This flag is used mainly for not repeating GMA command once
    > received MAC address.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@...com>
    
    Technically this means the driver will always send this command every
    time it configures if the associated NIC doesn't respond to this
    command, but that won't change the behaviour otherwise.

Yes Sam, you are right. 
    
    Reviewed-by: Samuel Mendoza-Jonas <sam@...dozajonas.com>
    
    > ---
    >  net/ncsi/ncsi-manage.c | 3 ---
    >  net/ncsi/ncsi-rsp.c    | 6 ++++++
    >  2 files changed, 6 insertions(+), 3 deletions(-)
    > 
    > diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
    > index 70fe02697544..e20b81514029 100644
    > --- a/net/ncsi/ncsi-manage.c
    > +++ b/net/ncsi/ncsi-manage.c
    > @@ -764,9 +764,6 @@ static int ncsi_gma_handler(struct ncsi_cmd_arg
    > *nca, unsigned int mf_id)
    >  		return -1;
    >  	}
    >  
    > -	/* Set the flag for GMA command which should only be called
    > once */
    > -	nca->ndp->gma_flag = 1;
    > -
    >  	/* Get Mac address from NCSI device */
    >  	return nch->handler(nca);
    >  }
    > diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c
    > index d5611f04926d..a94bb59793f0 100644
    > --- a/net/ncsi/ncsi-rsp.c
    > +++ b/net/ncsi/ncsi-rsp.c
    > @@ -627,6 +627,9 @@ static int ncsi_rsp_handler_oem_mlx_gma(struct
    > ncsi_request *nr)
    >  	saddr.sa_family = ndev->type;
    >  	ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
    >  	memcpy(saddr.sa_data, &rsp->data[MLX_MAC_ADDR_OFFSET],
    > ETH_ALEN);
    > +	/* Set the flag for GMA command which should only be called
    > once */
    > +	ndp->gma_flag = 1;
    > +
    >  	ret = ops->ndo_set_mac_address(ndev, &saddr);
    >  	if (ret < 0)
    >  		netdev_warn(ndev, "NCSI: 'Writing mac address to device
    > failed\n");
    > @@ -671,6 +674,9 @@ static int ncsi_rsp_handler_oem_bcm_gma(struct
    > ncsi_request *nr)
    >  	if (!is_valid_ether_addr((const u8 *)saddr.sa_data))
    >  		return -ENXIO;
    >  
    > +	/* Set the flag for GMA command which should only be called
    > once */
    > +	ndp->gma_flag = 1;
    > +
    >  	ret = ops->ndo_set_mac_address(ndev, &saddr);
    >  	if (ret < 0)
    >  		netdev_warn(ndev, "NCSI: 'Writing mac address to device
    > failed\n");