linux-kernel - Re: [PATCH 4.19 159/219] x86/crash: Add a forward declaration of struct kimage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191231082104.GA18654@amd>
Date:   Tue, 31 Dec 2019 09:21:04 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        kbuild test robot <lkp@...el.com>,
        Lianbo Jiang <lijiang@...hat.com>,
        Borislav Petkov <bp@...e.de>, bhe@...hat.com,
        d.hatayama@...itsu.com, dhowells@...hat.com, dyoung@...hat.com,
        ebiederm@...ssion.com, horms@...ge.net.au,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Jürgen Gross <jgross@...e.com>,
        kexec@...ts.infradead.org, Thomas Gleixner <tglx@...utronix.de>,
        Tom Lendacky <thomas.lendacky@....com>, vgoyal@...hat.com,
        x86-ml <x86@...nel.org>, Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 159/219] x86/crash: Add a forward declaration of
 struct kimage

On Sun 2019-12-29 18:19:21, Greg Kroah-Hartman wrote:
> From: Lianbo Jiang <lijiang@...hat.com>
> 
> [ Upstream commit 112eee5d06007dae561f14458bde7f2a4879ef4e ]
> 
> Add a forward declaration of struct kimage to the crash.h header because
> future changes will invoke a crash-specific function from the realmode
> init path and the compiler will complain otherwise like this:
> 
>   In file included from arch/x86/realmode/init.c:11:
>   ./arch/x86/include/asm/crash.h:5:32: warning: ‘struct kimage’ declared inside\

This is not needed in 4.19-stable, as
6f599d84231fd27e42f4ca2a786a6641e8cddf00 is not being backported
there. (But is simple enough not to do harm).

Best regards,
									Pavel

> @@ -2,6 +2,8 @@
>  #ifndef _ASM_X86_CRASH_H
>  #define _ASM_X86_CRASH_H
>  
> +struct kimage;
> +
>  int crash_load_segments(struct kimage *image);
>  int crash_copy_backup_region(struct kimage *image);
>  int crash_setup_memmap_entries(struct kimage *image,

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)