linux-kernel - Re: [PATCH v2 07/14] dt-bindings: phy: phy-cadence-torrent: Add clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Dec 2019 14:28:06 +0200
From:   Jyri Sarha <jsarha@...com>
To:     Yuti Amonkar <yamonkar@...ence.com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <kishon@...com>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <maxime@...no.tech>
CC:     <tomi.valkeinen@...com>, <praneeth@...com>, <mparab@...ence.com>,
        <sjakhade@...ence.com>
Subject: Re: [PATCH v2 07/14] dt-bindings: phy: phy-cadence-torrent: Add clock
 bindings

On 23/12/2019 17:15, Yuti Amonkar wrote:
> Add Torrent PHY reference clock bindings.This will not affect ABI as
> the driver has never been functional, and therefore do not exist in
> any active use case
> 

I think this could very well be a part of the first patch. There is no
requirement for the driver to actually use all properties in the binding.

> Signed-off-by: Yuti Amonkar <yamonkar@...ence.com>
> ---
>  .../devicetree/bindings/phy/phy-cadence-torrent.yaml         | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> index 3587312..907b627 100644
> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
> @@ -17,6 +17,14 @@ properties:
>    compatible:
>      const: cdns,torrent-phy
>  
> +  clocks:
> +    maxItems: 1
> +    description:
> +      PHY reference clock. Must contain an entry in clock-names.
> +
> +  clock-names:
> +    const: refclk
> +
>    reg:
>      items:
>        - description: Offset of the DPTX PHY configuration registers.
> @@ -46,6 +54,8 @@ properties:
>  
>  required:
>    - compatible
> +  - clocks
> +  - clock-names
>    - reg
>    - "#phy-cells"
>  
> @@ -60,5 +70,7 @@ examples:
>            num_lanes = <4>;
>            max_bit_rate = <8100>;
>            #phy-cells = <0>;
> +          clocks = <&ref_clk>;
> +          clock-names = "refclk";
>      };
>  ...
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki