linux-kernel - Re: [PATCH] ocfs2: make local header paths relative to C files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191231143331.9b77ee5709f2662c54d76a51@linux-foundation.org>
Date:   Tue, 31 Dec 2019 14:33:31 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Gang He <GHe@...e.com>
Cc:     "mark@...heh.com" <mark@...heh.com>,
        "jlbec@...lplan.org" <jlbec@...lplan.org>,
        "joseph.qi@...ux.alibaba.com" <joseph.qi@...ux.alibaba.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ocfs2-devel@....oracle.com" <ocfs2-devel@....oracle.com>
Subject: Re: [PATCH] ocfs2: make local header paths relative to C files

On Fri, 27 Dec 2019 02:30:15 +0000 Gang He <GHe@...e.com> wrote:

> From: Masahiro Yamada <masahiroy@...nel.org>
> 
> Gang He reports the failure of building fs/ocfs2/ as an external module
> of the kernel installed on the system:
> 
>  $ cd fs/ocfs2
>  $ make -C /lib/modules/`uname -r`/build M=`pwd` modules
> 
> If you want to make it work reliably, I'd recommend to remove ccflags-y
> from the Makefiles, and to make header paths relative to the C files.
> I think this is the correct usage of the #include "..." directive.
> 
> Reported-by: Gang He <ghe@...e.com>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Reviewed-by: Gang He <ghe@...e.com>

Your signed-off-by should appear here, since you were on the patch
delivery path.  I have made that change, OK?