linux-kernel - Re: [PATCH] spi: spi-dw: Add lock protect dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191231002928.GD3897@sirena.org.uk>
Date:   Tue, 31 Dec 2019 00:29:28 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "wuxu.wu" <wuxu.wu@...wei.com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        hushiyuan@...wei.com
Subject: Re: [PATCH] spi: spi-dw: Add lock protect dw_spi rx/tx to prevent
 concurrent calls

On Fri, Dec 27, 2019 at 11:51:09AM +0800, wuxu.wu wrote:

>  static void dw_writer(struct dw_spi *dws)
>  {
> -	u32 max = tx_max(dws);
> +	u32 max
>  	u16 txw = 0;

This is going to break the build, there's a missing ; in the
declaration of max.  Otherwise this looks good.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)