linux-kernel - Re: [v2,net-next] enetc: add support time specific departure base on the qos etf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191230.202652.128958107020164612.davem@davemloft.net>
Date:   Mon, 30 Dec 2019 20:26:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     po.liu@....com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        vinicius.gomes@...el.com, claudiu.manoil@....com,
        vladimir.oltean@....com, alexandru.marginean@....com,
        xiaoliang.yang_1@....com, roy.zang@....com, mingkai.hu@....com,
        jerry.huang@....com, leoyang.li@....com, ivan.khoronzhuk@...aro.org
Subject: Re: [v2,net-next] enetc: add support time specific departure base
 on the qos etf

From: Po Liu <po.liu@....com>
Date: Fri, 27 Dec 2019 03:12:18 +0000

> v2:
> - fix the csum and time specific deaprture return directly if both
> offloading enabled

The test is in the wrong location.

You are testing at run time when packets are being transmitted.

Instead, you should test when the configuration change is made
which creates the conflict, and disallow the configuration change
in such a conflicting case.