linux-kernel - RE: [PATCH v8 02/13] exfat: add super block operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000701d5c132$bed73c80$3c85b580$@samsung.com>
Date:   Thu, 2 Jan 2020 15:06:16 +0900
From:   "Namjae Jeon" <namjae.jeon@...sung.com>
To:     'Pali Rohár' <pali.rohar@...il.com>
Cc:     <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <gregkh@...uxfoundation.org>, <valdis.kletnieks@...edu>,
        <hch@....de>, <sj1557.seo@...sung.com>, <linkinjeon@...il.com>
Subject: RE: [PATCH v8 02/13] exfat: add super block operations

> > +static const struct fs_parameter_spec exfat_param_specs[] = {
> > +	fsparam_u32("uid",			Opt_uid),
> > +	fsparam_u32("gid",			Opt_gid),
> > +	fsparam_u32oct("umask",			Opt_umask),
> > +	fsparam_u32oct("dmask",			Opt_dmask),
> > +	fsparam_u32oct("fmask",			Opt_fmask),
> > +	fsparam_u32oct("allow_utime",		Opt_allow_utime),
> > +	fsparam_string("iocharset",		Opt_charset),
> > +	fsparam_flag("utf8",			Opt_utf8),
> 
> Hello! What is the purpose of having extra special "utf8" mount option?
> Is not one "iocharset=utf8" option enough?
utf8 nls_table supports utf8<->utf32 conversion and does not support
surrogate character conversion. The utf8 option can support the surrogate
character conversion of utf16 using utf16s_to_utf8s/utf8s_to_utf16s of
the nls base.

Thanks!